Audio: multiband_drc: multiband drc code re-organize and split #8526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
btian1
commented
Nov 27, 2023
•
btian1
commented
- Move header file from include path to module inside folder.
- Move one inline function to header file and remove one inline function.
- split multiband DRC with ipc3 and ipc4 specific code.
lgirdwood
approved these changes
Nov 27, 2023
Move header file from include path to module inside folder. Signed-off-by: Baofeng Tian <[email protected]>
btian1
force-pushed
the
multiband_drc_refine
branch
from
7a0c945
to
0a2cfd0
Compare
Move one inlined function to header file, for the second functions, it was called 4 times in current module and not time critical, no need inline. Signed-off-by: Baofeng Tian <[email protected]>
btian1
force-pushed
the
multiband_drc_refine
branch
from
0f9f649
to
d2a8682
Compare
btian1
changed the title
lyakh
approved these changes
Nov 29, 2023
|
@btian1 any reason why draft ? |
just waiting for CI results, now opened. |
btian1
requested review from
marc-hb,
a team,
plbossart,
mmaka1,
lbetlej,
dbaluta and
kv2019i
as code owners
marc-hb
reviewed
Nov 30, 2023
zephyr/CMakeLists.txt
Outdated
| elseif(CONFIG_IPC_MAJOR_4) | ||
| zephyr_library_sources_ifdef(CONFIG_COMP_MULTIBAND_DRC | ||
| ${SOF_AUDIO_PATH}/multiband_drc/multiband_drc.c | ||
| ${SOF_AUDIO_PATH}/multiband_drc/multiband_drc_generic.c |
There was a problem hiding this comment.
No copy/paste, see #8514 (comment)
btian1
force-pushed
the
multiband_drc_refine
branch
from
d2a8682
to
a919009
Compare
Split out ipc3 and ipc4 specific code from mulitband_drc.c. Signed-off-by: Baofeng Tian <[email protected]>
|
SOFCI TEST |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.